aboutsummaryrefslogtreecommitdiff
path: root/src/validation.cpp
diff options
context:
space:
mode:
authorMartin Zumsande <mzumsande@gmail.com>2023-02-06 15:05:33 -0500
committerMartin Zumsande <mzumsande@gmail.com>2023-02-16 17:58:52 -0500
commit57ef2a4812f443b2d734f43cebf3ef5038da83f2 (patch)
tree4a6adc2b45ff7e36e47e6d5b97e03ee4f3c9b43d /src/validation.cpp
parent0c7785bb2540b69564104767d38342704230cbc2 (diff)
downloadbitcoin-57ef2a4812f443b2d734f43cebf3ef5038da83f2.tar.xz
validation: report if pruning prevents completion of verification
Now the verifychain RPC returns false if the checks didn't finish because the blocks requested to be queried have been pruned.
Diffstat (limited to 'src/validation.cpp')
-rw-r--r--src/validation.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/validation.cpp b/src/validation.cpp
index 4da52b7d8b..de1a4ce91f 100644
--- a/src/validation.cpp
+++ b/src/validation.cpp
@@ -4081,6 +4081,7 @@ VerifyDBResult CVerifyDB::VerifyDB(
int nGoodTransactions = 0;
BlockValidationState state;
int reportDone = 0;
+ bool skipped_no_block_data{false};
bool skipped_l3_checks{false};
LogPrintf("Verification progress: 0%%\n");
@@ -4100,7 +4101,8 @@ VerifyDBResult CVerifyDB::VerifyDB(
if ((chainstate.m_blockman.IsPruneMode() || is_snapshot_cs) && !(pindex->nStatus & BLOCK_HAVE_DATA)) {
// If pruning or running under an assumeutxo snapshot, only go
// back as far as we have data.
- LogPrintf("VerifyDB(): block verification stopping at height %d (pruning, no data)\n", pindex->nHeight);
+ LogPrintf("VerifyDB(): block verification stopping at height %d (no data). This could be due to pruning or use of an assumeutxo snapshot.\n", pindex->nHeight);
+ skipped_no_block_data = true;
break;
}
CBlock block;
@@ -4188,6 +4190,9 @@ VerifyDBResult CVerifyDB::VerifyDB(
if (skipped_l3_checks) {
return VerifyDBResult::SKIPPED_L3_CHECKS;
}
+ if (skipped_no_block_data) {
+ return VerifyDBResult::SKIPPED_MISSING_BLOCKS;
+ }
return VerifyDBResult::SUCCESS;
}