diff options
author | John Newbery <john@johnnewbery.com> | 2020-03-23 10:45:34 -0400 |
---|---|---|
committer | John Newbery <john@johnnewbery.com> | 2020-04-21 14:19:15 -0400 |
commit | 21fa0a44abe8c1b5c452e097eab20cf0ae988805 (patch) | |
tree | 4d3c982ba590833e9e949c55ec504e3b65fdc1bf /src/validation.cpp | |
parent | 2685c214cce4b07695273503e60350e3f05fe3e2 (diff) |
[docs] use consistent naming for possible_overwrite
And other general comment improvements for adding coins.
Diffstat (limited to 'src/validation.cpp')
-rw-r--r-- | src/validation.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/validation.cpp b/src/validation.cpp index bab04b8e34..bb4aae39db 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -1669,10 +1669,11 @@ int ApplyTxInUndo(Coin&& undo, CCoinsViewCache& view, const COutPoint& out) return DISCONNECT_FAILED; // adding output for transaction without known metadata } } - // The potential_overwrite parameter to AddCoin is only allowed to be false if we know for - // sure that the coin did not already exist in the cache. As we have queried for that above - // using HaveCoin, we don't need to guess. When fClean is false, a coin already existed and - // it is an overwrite. + // If the coin already exists as an unspent coin in the cache, then the + // possible_overwrite parameter to AddCoin must be set to true. We have + // already checked whether an unspent coin exists above using HaveCoin, so + // we don't need to guess. When fClean is false, an unspent coin already + // existed and it is an overwrite. view.AddCoin(out, std::move(undo), !fClean); return fClean ? DISCONNECT_OK : DISCONNECT_UNCLEAN; |