diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-06-13 09:21:40 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-06-13 09:21:46 +0200 |
| commit | 9c1ec689f353d3d7c34695a074f82bb2ea449538 (patch) | |
| tree | 9ae77f0f3e396f6557e6aacb500e680465d4eb60 /src/validation.cpp | |
| parent | b0e5fbf6fad854ad03ce092ff5f1582166e5b24e (diff) | |
| parent | 6d7e46ce23217da53ff52f535879c393c02fa2b2 (diff) | |
| download | bitcoin-9c1ec689f353d3d7c34695a074f82bb2ea449538.tar.xz | |
Merge bitcoin/bitcoin#22102: Remove `Warning:` from warning message printed for unknown new rules
6d7e46ce23217da53ff52f535879c393c02fa2b2 Remove `Warning:` (Prayank)
Pull request description:
Reason: I noticed that `Warning` is printed 2 times in `-getinfo` while reviewing https://github.com/bitcoin/bitcoin/pull/21832#issuecomment-851004943
Same string is used for GUI, log and stderr. If we need to add `Warning:` in GUI or other place we can always prepend to this string.
CLI:
```
Warnings: Unknown new rules activated (versionbit 28)
```
GUI:
ACKs for top commit:
MarcoFalke:
review ACK 6d7e46ce23217da53ff52f535879c393c02fa2b2
Tree-SHA512: 25760cf6d850f6c2216d651fa46574d2d21a9d58f4577ecb58f9566ea8cd07bfcd6679bb8a1f53575e441b02d295306f492c0c99a48c909e60e5d977ec1861f6
Diffstat (limited to 'src/validation.cpp')
| -rw-r--r-- | src/validation.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/validation.cpp b/src/validation.cpp index 21785ba208..b48e49a10b 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -2251,7 +2251,7 @@ static void UpdateTip(CTxMemPool& mempool, const CBlockIndex* pindexNew, const C WarningBitsConditionChecker checker(bit); ThresholdState state = checker.GetStateFor(pindex, chainParams.GetConsensus(), warningcache[bit]); if (state == ThresholdState::ACTIVE || state == ThresholdState::LOCKED_IN) { - const bilingual_str warning = strprintf(_("Warning: unknown new rules activated (versionbit %i)"), bit); + const bilingual_str warning = strprintf(_("Unknown new rules activated (versionbit %i)"), bit); if (state == ThresholdState::ACTIVE) { DoWarning(warning); } else { |