diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-10-08 14:42:17 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-10-24 14:58:34 -0400 |
| commit | fa928134075220254a15107c1d9702f4e66271f8 (patch) | |
| tree | d21688f45f6634ef8ab2cb204991089a1daa8682 /src/validation.cpp | |
| parent | d53828cb79688d72a18d2cc550dcd1dfe2d3dd85 (diff) | |
| download | bitcoin-fa928134075220254a15107c1d9702f4e66271f8.tar.xz | |
consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it
Diffstat (limited to 'src/validation.cpp')
| -rw-r--r-- | src/validation.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/validation.cpp b/src/validation.cpp index 70b847d3b0..f1abcadefc 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -3301,9 +3301,8 @@ bool CheckBlock(const CBlock& block, CValidationState& state, const Consensus::P return state.Invalid(ValidationInvalidReason::CONSENSUS, false, "bad-cb-multiple", "more than one coinbase"); // Check transactions - // Must check for duplicate inputs (see CVE-2018-17144) for (const auto& tx : block.vtx) - if (!CheckTransaction(*tx, state, true)) + if (!CheckTransaction(*tx, state)) return state.Invalid(state.GetReason(), false, state.GetRejectReason(), strprintf("Transaction check failed (tx hash %s) %s", tx->GetHash().ToString(), state.GetDebugMessage())); |