diff options
author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-11-01 14:26:19 +0100 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-11-01 14:26:23 +0100 |
commit | db2f83ed463b025e77a5527c3052980f971b8398 (patch) | |
tree | 743cec3eda2ca742bb5e1115896f90aa074afbc7 /src/validation.cpp | |
parent | c95832da87ac73dab38d61574a633d4110a6c47a (diff) | |
parent | b296bf1496b213eaea53cac0a734679fed7a42f5 (diff) | |
download | bitcoin-db2f83ed463b025e77a5527c3052980f971b8398.tar.xz |
Merge #11511: [Init] Remove redundant exit(EXIT_FAILURE) instances and replace with return false
b296bf1 Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return false (donaloconnor)
Pull request description:
While reviewing the bitcoin code I noticed that there are a few exit(EXIT_FAILURE) at various places in the AppInit function.
This function returns to main() which will return/exit with EXIT_FAILURE so returning false instead of an explicit exit(EXIT_FAILURE) seems to be cleaner.
This PR attempts to make things a bit more consistent.
There is a subtle difference between exit() and return from main in that the exit() will not clean up any local vars but I don't think this makes a difference in this case. Using exit() might even lead to bugs in the future where the dtor of local objects are expected to be called.
Tree-SHA512: 7d104c3a752b4e7d7bc2382ef7e62543462988f1bbf13dd4077fbeff5399729b76c71a4352556f188b8d306604232477466f5bb827b58a6f3f6273f2370e1faa
Diffstat (limited to 'src/validation.cpp')
0 files changed, 0 insertions, 0 deletions