diff options
author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-03-22 14:28:19 +0100 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-03-22 14:28:37 +0100 |
commit | a6926b065d654a448937f9f1e2999ac48d50a984 (patch) | |
tree | f08bb4e6b86085b2d068140d82f86d5eb86f1213 /src/utilstrencodings.h | |
parent | 6d36f599f88e26ba39557d7b606ac9a3c8c3165a (diff) | |
parent | 5fbf7c478a996974502d5d787b2ccf2fcc91ac78 (diff) | |
download | bitcoin-a6926b065d654a448937f9f1e2999ac48d50a984.tar.xz |
Merge #12048: Use best-fit strategy in Arena, now O(log(n)) instead O(n)
5fbf7c4 fix nits: variable naming, typos (Martin Ankerl)
1e0ee90 Use best-fit strategy in Arena, now O(log(n)) instead O(n) (Martin Ankerl)
Pull request description:
This replaces the first-fit algorithm used in the Arena with a best-fit. According to "Dynamic Storage Allocation: A Survey and Critical Review", Wilson et. al. 1995, http://www.scs.stanford.edu/14wi-cs140/sched/readings/wilson.pdf, both startegies work well in practice.
The advantage of using best-fit is that we can switch the O(n) allocation to O(log(n)). Additionally, some previously O(log(n)) operations are now O(1) operations by using hash maps. The end effect is that the benchmark runs about 2.5 times faster on my machine:
# Benchmark, evals, iterations, total, min, max, median
old: BenchLockedPool, 5, 530, 5.25749, 0.00196938, 0.00199755, 0.00198172
new: BenchLockedPool, 5, 1300, 5.11313, 0.000781493, 0.000793314, 0.00078606
I've run all unit tests and benchmarks, and increased the number of iterations so that BenchLockedPool takes about 5 seconds again.
Tree-SHA512: 6551e384671f93f10c60df530a29a1954bd265cc305411f665a8756525e5afe2873a8032c797d00b6e8c07e16d9827465d0b662875433147381474a44119ccce
Diffstat (limited to 'src/utilstrencodings.h')
0 files changed, 0 insertions, 0 deletions