diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-11-22 11:36:37 -0500 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-11-22 11:37:17 -0500 |
| commit | 2a97f192ea92e7accb21288c3c5822f480808566 (patch) | |
| tree | 835b3bba196090397a29880d1c4ef9635a9e1e89 /src/util | |
| parent | 708cbb172dbf61dbb14671ffd98be3782cd7cd42 (diff) | |
| parent | fa21ca09a807e18476babe2651ad62df6477bbf0 (diff) | |
| download | bitcoin-2a97f192ea92e7accb21288c3c5822f480808566.tar.xz | |
Merge #14771: test: Add BOOST_REQUIRE to getters returning optional
fa21ca09a8 test: Add BOOST_REQUIRE to getters returning optional (MarcoFalke)
Pull request description:
Usually the returned value is already checked for equality, but for sanity we might as well require that the getter successfully returned.
Tree-SHA512: 0d613a9a721c61bd7a115ebc681a0890df09b8e5775f176ac18b3a586f2ca57bee0b5b816f5a7c314ff3ac6cbb2a4d9c434f8459e054a7c8a6934a75f0120c2a
Diffstat (limited to 'src/util')
| -rw-r--r-- | src/util/system.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/util/system.h b/src/util/system.h index 66049dfb3a..dca32cc6fc 100644 --- a/src/util/system.h +++ b/src/util/system.h @@ -151,7 +151,7 @@ protected: std::map<OptionsCategory, std::map<std::string, Arg>> m_available_args GUARDED_BY(cs_args); std::set<std::string> m_config_sections GUARDED_BY(cs_args); - bool ReadConfigStream(std::istream& stream, std::string& error, bool ignore_invalid_keys = false); + NODISCARD bool ReadConfigStream(std::istream& stream, std::string& error, bool ignore_invalid_keys = false); public: ArgsManager(); @@ -162,7 +162,7 @@ public: void SelectConfigNetwork(const std::string& network); NODISCARD bool ParseParameters(int argc, const char* const argv[], std::string& error); - bool ReadConfigFiles(std::string& error, bool ignore_invalid_keys = false); + NODISCARD bool ReadConfigFiles(std::string& error, bool ignore_invalid_keys = false); /** * Log warnings for options in m_section_only_args when |