diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-05-19 13:59:20 +0200 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-05-19 14:05:33 +0200 |
| commit | 087812864bd34d196a1f4a2e6d392fb86382c5eb (patch) | |
| tree | 983ef037540e8389bc82e8cb5a8d51766e25e96b /src/util/sock.h | |
| parent | 4da26fb85d6d6d205a2794ccb98beee1302b4a25 (diff) | |
| parent | 9938d610b043bf018e0b34d92e3daaffe1f17fcc (diff) | |
Merge bitcoin/bitcoin#21962: wallet: refactor: dedup sqlite PRAGMA access
9938d610b043bf018e0b34d92e3daaffe1f17fcc wallet: refactor: dedup sqlite PRAGMA assignments (Sebastian Falbesoner)
dca8ef586c57075587e6cd44db88eaa5c4b707c7 wallet: refactor: dedup sqlite PRAGMA integer reads (Sebastian Falbesoner)
Pull request description:
This refactoring PR deduplicates repeated SQLite access to PRAGMA settings. Two functions `ReadPragmaInteger(...)` (reads a single integer value via statement `PRAGMA key`) and `SetPragma(...)` (sets a key to specified value via statement `PRAGMA key = value`) are introduced for this purpose.
This should be more readable and less error-prone, e.g. in case other PRAGMA settings need to be read/set in the future or the error handling has to be adapted.
ACKs for top commit:
achow101:
Code Review ACK 9938d610b043bf018e0b34d92e3daaffe1f17fcc
laanwj:
Looks good to me now, code review ACK 9938d610b043bf018e0b34d92e3daaffe1f17fcc
Tree-SHA512: 5332788ead6d8d652e28cb0cef1bf0be2b22d6744f8d02dd9e04a4a68e32e14d4a21f94d9b940c37a0d815be3f0091d956c9f6e269b0a6819b62b40482d3bbd2
Diffstat (limited to 'src/util/sock.h')
0 files changed, 0 insertions, 0 deletions