diff options
| author | glozow <gloriajzhao@gmail.com> | 2021-08-20 13:01:07 +0100 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2021-08-24 15:47:21 +0100 |
| commit | badb9b11a6f7e1e693cecc8cd5aae55a197d70e2 (patch) | |
| tree | 03ac91f1d6279ad47badf384d131de33cf6749b5 /src/util/rbf.h | |
| parent | e0df41d7d584b854c2914d4afe7b21e0af3fbf69 (diff) | |
call SignalsOptInRBF instead of checking all inputs
Diffstat (limited to 'src/util/rbf.h')
| -rw-r--r-- | src/util/rbf.h | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/util/rbf.h b/src/util/rbf.h index 6a20b37de5..4eb44b904f 100644 --- a/src/util/rbf.h +++ b/src/util/rbf.h @@ -11,8 +11,15 @@ class CTransaction; static const uint32_t MAX_BIP125_RBF_SEQUENCE = 0xfffffffd; -// Check whether the sequence numbers on this transaction are signaling -// opt-in to replace-by-fee, according to BIP 125 +/** Check whether the sequence numbers on this transaction are signaling +* opt-in to replace-by-fee, according to BIP 125. +* Allow opt-out of transaction replacement by setting +* nSequence > MAX_BIP125_RBF_SEQUENCE (SEQUENCE_FINAL-2) on all inputs. +* +* SEQUENCE_FINAL-1 is picked to still allow use of nLockTime by +* non-replaceable transactions. All inputs rather than just one +* is for the sake of multi-party protocols, where we don't +* want a single party to be able to disable replacement. */ bool SignalsOptInRBF(const CTransaction &tx); #endif // BITCOIN_UTIL_RBF_H |