aboutsummaryrefslogtreecommitdiff
path: root/src/util/rbf.cpp
diff options
context:
space:
mode:
authorRussell Yanofsky <russ@yanofsky.org>2020-02-11 16:53:53 -0500
committerfanquake <fanquake@gmail.com>2020-02-28 12:07:39 +0800
commit48fef5ebae58b0730619182007218941bd339768 (patch)
tree769aaae12b7df5ebba46b5c05ffd687f05d6b3a5 /src/util/rbf.cpp
parent1964561a3a5eacbb27139e9125859854c0e77437 (diff)
gui: Fix race in WalletModel::pollBalanceChanged
Poll function was wrongly setting cached height to the current chain height instead of the chain height at the time of polling. This bug could cause balances to appear out of date, and was first introduced https://github.com/bitcoin/bitcoin/pull/10244/commits/a0704a8996bb950ae3c4d5b5a30e9dfe34cde1d3#r378452145 Before that commit, there wasn't a problem because cs_main was held during the poll update. Currently, the problem should be rare. But if 8937d99ce81a27ae5e1012a28323c0e26d89c50b from #17954 were merged, the problem would get worse, because the wrong cachedNumBlocks value would be set if the wallet was polled in the interval between a block being connected and it processing the BlockConnected notification. MarcoFalke <falke.marco@gmail.com> also points out that a0704a8996b could lead to GUI hangs as well, because previously the pollBalanceChanged method, which runs on the GUI thread, would only make a nonblocking TRY_LOCK(cs_main) call, but after could make blocking LOCK(cs_main) calls, potentially locking up the GUI. Thanks to John Newbery <john@johnnewbery.com> for finding this bug this while reviewing https://github.com/bitcoin/bitcoin/pull/17954. Github-Pull: #18123 Rebased-From: bf36a3ccc212ad4d7c5cb8f26d7a22e279fe3cec
Diffstat (limited to 'src/util/rbf.cpp')
0 files changed, 0 insertions, 0 deletions