diff options
| author | AtsukiTak <takatomgoo@gmail.com> | 2018-07-21 18:53:54 +0900 |
|---|---|---|
| committer | AtsukiTak <takatomgoo@gmail.com> | 2018-07-22 03:16:53 +0900 |
| commit | 9544a3f3fc5d900fbf90c5347821a7fcafc058b0 (patch) | |
| tree | b0f4ef93f2271bd149907cecfdbb4d271e6adc64 /src/util.h | |
| parent | 07ce278455757fb46dab95fb9b97a3f6b1b84faf (diff) | |
| download | bitcoin-9544a3f3fc5d900fbf90c5347821a7fcafc058b0.tar.xz | |
tiny refactor for ArgsManager
This commit contains 2 refactors.
1. mark "const" on ArgsManager::GetHelpMessage and IsArgKnown.
2. remove unused "error" argument from ArgsManager::IsArgKnown.
Firstly, I mark "const" on where it is possible to. It is mentioned
before (e.g. https://github.com/bitcoin/bitcoin/pull/13190#pullrequestreview-118823133).
And about 2nd change, ArgsManager::IsArgKnown was added at commit #4f8704d which was
merged at PR #13112. But from its beggining, "error" argument never be used.
I think it should be refactored.
Diffstat (limited to 'src/util.h')
| -rw-r--r-- | src/util.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/util.h b/src/util.h index f8bcc0192c..2c22720a6b 100644 --- a/src/util.h +++ b/src/util.h @@ -276,12 +276,12 @@ public: /** * Get the help string */ - std::string GetHelpMessage(); + std::string GetHelpMessage() const; /** * Check whether we know of this arg */ - bool IsArgKnown(const std::string& key, std::string& error); + bool IsArgKnown(const std::string& key) const; }; extern ArgsManager gArgs; |