diff options
| author | Olivier Langlois <olivier@olivierlanglois.net> | 2013-10-10 12:35:51 -0400 |
|---|---|---|
| committer | Olivier Langlois <olivier@olivierlanglois.net> | 2013-10-27 23:04:52 -0400 |
| commit | f171ec0c7d084b6bb163d1466edd814cf4dcbc93 (patch) | |
| tree | cb0708afc624eeb68a0b0b5db0aca19e9cc58984 /src/util.cpp | |
| parent | 15b48ab03612952b355cdd411cc541668d147bfb (diff) | |
| download | bitcoin-f171ec0c7d084b6bb163d1466edd814cf4dcbc93.tar.xz | |
Make util phexdigit array reusable
class template base_uint had its own private lookup table.
This is saving 256 bytes per instantiation.
The result is not spectacular as bitcoin-qt has only shrinked of
about 1Kb but it is still valid improvement.
Also, I have replaced a for loop with a memset() call.
Made CBigNum::SetHex() use the new HexDigit() function.
Signed-off-by: Olivier Langlois <olivier@olivierlanglois.net>
Diffstat (limited to 'src/util.cpp')
| -rw-r--r-- | src/util.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/util.cpp b/src/util.cpp index 73428b4c22..e0b738dcc6 100644 --- a/src/util.cpp +++ b/src/util.cpp @@ -455,7 +455,7 @@ bool ParseMoney(const char* pszIn, int64& nRet) } -static const signed char phexdigit[256] = +const signed char p_util_hexdigit[256] = { -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1, -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1, -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1, @@ -475,9 +475,9 @@ static const signed char phexdigit[256] = bool IsHex(const string& str) { - BOOST_FOREACH(unsigned char c, str) + BOOST_FOREACH(char c, str) { - if (phexdigit[c] < 0) + if (HexDigit(c) < 0) return false; } return (str.size() > 0) && (str.size()%2 == 0); @@ -491,11 +491,11 @@ vector<unsigned char> ParseHex(const char* psz) { while (isspace(*psz)) psz++; - signed char c = phexdigit[(unsigned char)*psz++]; + signed char c = HexDigit(*psz++); if (c == (signed char)-1) break; unsigned char n = (c << 4); - c = phexdigit[(unsigned char)*psz++]; + c = HexDigit(*psz++); if (c == (signed char)-1) break; n |= c; |