diff options
| author | fanquake <fanquake@gmail.com> | 2020-06-08 13:14:38 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-06-08 13:47:58 +0800 |
| commit | 807b9f811479a2b5a4b29e44fe915e054bd92fc3 (patch) | |
| tree | 45914040b488fc0eaeadf32f67f5a2c4545d1ee2 /src/txmempool.h | |
| parent | b3091b2be7d1e5ab86d7380a884d4f23a5e9c9b7 (diff) | |
| parent | fac6b9b938230d24c13fcb6e9be28515d674c6c8 (diff) | |
| download | bitcoin-807b9f811479a2b5a4b29e44fe915e054bd92fc3.tar.xz | |
Merge #19188: test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field]
fac6b9b938230d24c13fcb6e9be28515d674c6c8 test: Avoid overwriting the NodeContext member of the testing setup (MarcoFalke)
fa16e7816b886b82d36457b0d8edc773cba76421 build: Add -Wshadow-field (MarcoFalke)
Pull request description:
Adding this warning will eliminate unexpected test failures and hard to review code. Moreover, there shouldn't be a use case in Bitcoin Core that relies on fields to be shadowed.
ACKs for top commit:
fanquake:
ACK fac6b9b938230d24c13fcb6e9be28515d674c6c8 - Warnings compiling fa16e7816b886b82d36457b0d8edc773cba76421 are below. No warnings with fac6b9b938230d24c13fcb6e9be28515d674c6c8. The `-Wshadow-field` diagnostic has been available in Clang since 5.0.0. It's not available for GCC.
practicalswift:
ACK fac6b9b938230d24c13fcb6e9be28515d674c6c8 -- patch looks correct
hebasto:
ACK fac6b9b938230d24c13fcb6e9be28515d674c6c8, tested on Linux Mint 19.3 (x86_64):
Tree-SHA512: 824874ca10877efea7463cf934a2953147f3f99c486f04679426c14ff968975d8652cbba5729bfb7cb2c86c637ade5d1e5b873d611c06bad013a7cad8427e2bf
Diffstat (limited to 'src/txmempool.h')
0 files changed, 0 insertions, 0 deletions