aboutsummaryrefslogtreecommitdiff
path: root/src/txdb.cpp
diff options
context:
space:
mode:
authorMatt Corallo <git@bluematt.me>2017-04-17 11:41:10 -0400
committerPieter Wuille <pieter.wuille@gmail.com>2017-06-26 10:46:51 -0700
commitd6af06d68aae985436cbc942f0d11078041d121b (patch)
treea8af3452e747b038bc50957aae8b47a9e8585ee5 /src/txdb.cpp
parenteaca1b7b08b4911292d49efbce8471cbc9ca0e1c (diff)
Dont create pcoinsTip until after ReplayBlocks.
This requires that we not access pcoinsTip in InitBlockIndex's FlushStateToDisk (so we just skip it until later in AppInitMain) and the LoadChainTip in LoadBlockIndex (which there is already one later in AppinitMain, after ReplayBlocks, so skipping it there is fine). Includes some simplifications by Suhas Daftuar and Pieter Wuille.
Diffstat (limited to 'src/txdb.cpp')
-rw-r--r--src/txdb.cpp8
1 files changed, 1 insertions, 7 deletions
diff --git a/src/txdb.cpp b/src/txdb.cpp
index 7de11cc617..4cdfc7d6f5 100644
--- a/src/txdb.cpp
+++ b/src/txdb.cpp
@@ -85,6 +85,7 @@ bool CCoinsViewDB::BatchWrite(CCoinsMap &mapCoins, const uint256 &hashBlock) {
size_t changed = 0;
size_t batch_size = (size_t)GetArg("-dbbatchsize", nDefaultDbBatchSize);
int crash_simulate = GetArg("-dbcrashratio", 0);
+ assert(!hashBlock.IsNull());
uint256 old_tip = GetBestBlock();
if (old_tip.IsNull()) {
@@ -96,13 +97,6 @@ bool CCoinsViewDB::BatchWrite(CCoinsMap &mapCoins, const uint256 &hashBlock) {
}
}
- if (hashBlock.IsNull()) {
- // Initial flush, nothing to write.
- assert(mapCoins.empty());
- assert(old_tip.IsNull());
- return true;
- }
-
// In the first batch, mark the database as being in the middle of a
// transition from old_tip to hashBlock.
// A vector is used for future extensibility, as we may want to support