diff options
| author | Pieter Wuille <pieter.wuille@gmail.com> | 2017-07-07 19:09:55 -0700 |
|---|---|---|
| committer | Pieter Wuille <pieter.wuille@gmail.com> | 2018-03-13 17:04:31 -0700 |
| commit | 172f5fa738d419efda99542e2ad2a0f4db5be580 (patch) | |
| tree | 49cf2358dac3b441f03f39fd7329c796ebfe474c /src/txdb.cpp | |
| parent | 2761bca99753951e1ad8bf51e3fce8fd309b4612 (diff) | |
| download | bitcoin-172f5fa738d419efda99542e2ad2a0f4db5be580.tar.xz | |
Support deserializing into temporaries
Currently, the READWRITE macro cannot be passed any non-const temporaries, as
the SerReadWrite function only accepts lvalue references.
Deserializing into a temporary is very common, however. See for example
things like 's >> VARINT(n)'. The VARINT macro produces a temporary wrapper
that holds a reference to n.
Fix this by accepting non-const rvalue references instead of lvalue references.
We don't propagate the rvalue-ness down, as there are no useful optimizations
that only apply to temporaries.
Then use this new functionality to get rid of many (but not all) uses of the
'REF' macro (which casts away constness).
Diffstat (limited to 'src/txdb.cpp')
| -rw-r--r-- | src/txdb.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/txdb.cpp b/src/txdb.cpp index 293d43c7b3..7a1d920117 100644 --- a/src/txdb.cpp +++ b/src/txdb.cpp @@ -348,7 +348,7 @@ public: vout.assign(vAvail.size(), CTxOut()); for (unsigned int i = 0; i < vAvail.size(); i++) { if (vAvail[i]) - ::Unserialize(s, REF(CTxOutCompressor(vout[i]))); + ::Unserialize(s, CTxOutCompressor(vout[i])); } // coinbase height ::Unserialize(s, VARINT(nHeight)); |