diff options
| author | merge-script <fanquake@gmail.com> | 2024-04-24 22:57:50 +0800 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-04-24 22:57:50 +0800 |
| commit | 50729c060907b69543755a8e1ed6b0d32d071a8a (patch) | |
| tree | c1cf3bf6a56e168e5985ad05fff86186694ac717 /src/test | |
| parent | d822d4e849646a455aa360efd4a48a546ecc5950 (diff) | |
| parent | 08f756bd370c3e100b186c7e24bef6a033575b29 (diff) | |
Merge bitcoin/bitcoin#29910: refactor: Rename `subprocess.hpp` to follow our header name conventions
08f756bd370c3e100b186c7e24bef6a033575b29 Replace locale-dependent `std::strerror` with `SysErrorString` (Hennadii Stepanov)
d8e4ba4d0568769782b8c19c82e955c4aee73477 refactor: Rename `subprocess.hpp` to follow our header name conventions (Hennadii Stepanov)
Pull request description:
This PR renames the header `*.hpp` --> `*.h` and adjusts the header guard name, which makes it available for processing by linters.
Fixed the following linter warning:
```
The locale dependent function strerror(...) appears to be used:
src/util/subprocess.h: std::runtime_error( err_msg + ": " + std::strerror(err_code) )
Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale-dependent functions if possible.
Advice not applicable in this specific case? Add an exception by updating the ignore list in /bitcoin/test/lint/lint-locale-dependence.py
^---- failure generated from lint-locale-dependence.py
```
ACKs for top commit:
TheCharlatan:
ACK 08f756bd370c3e100b186c7e24bef6a033575b29
Tree-SHA512: 57a2f01c20eb9552481e428a4969bd59e9ada9f784fe1a45cb62aa9c9152c8e950d336854f45af0e2e5dc7c7b2a1fb216c8f832e3d6ccfb457ad71b6e423231e
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/system_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/system_tests.cpp b/src/test/system_tests.cpp index 8aab2b565c..2de147deea 100644 --- a/src/test/system_tests.cpp +++ b/src/test/system_tests.cpp @@ -11,7 +11,7 @@ #include <univalue.h> #ifdef ENABLE_EXTERNAL_SIGNER -#include <util/subprocess.hpp> +#include <util/subprocess.h> #endif // ENABLE_EXTERNAL_SIGNER #include <boost/test/unit_test.hpp> |