diff options
author | MacroFake <falke.marco@gmail.com> | 2022-08-10 19:23:29 +0200 |
---|---|---|
committer | MacroFake <falke.marco@gmail.com> | 2022-08-10 19:23:35 +0200 |
commit | 251c535800c492b10332ea0774453e02bd9a24aa (patch) | |
tree | 05f776d66c2bdca457b1dd659b22d6108b923f09 /src/test | |
parent | f89ce1fdb561d5091bc6e211809ec35031cb63a7 (diff) | |
parent | b4a5ab96b42957a0e2110525b9e2e450deda09c1 (diff) | |
download | bitcoin-251c535800c492b10332ea0774453e02bd9a24aa.tar.xz |
Merge bitcoin/bitcoin#25810: scripted-diff: test: rename `MAX_{ANCESTORS,DESCENDANTS}` to `DEFAULT_{ANCESTOR,DESCENDANT}_LIMIT`
b4a5ab96b42957a0e2110525b9e2e450deda09c1 test: refactor: deduplicate `DEFAULT_{ANCESTOR,DESCENDANT}_LIMIT` constants (Sebastian Falbesoner)
0fda1c7df6165a60f63ced139ed10169f5df55f8 scripted-diff: test: rename `MAX_{ANCESTORS,DESCENDANTS}` to `DEFAULT_{ANCESTOR,DESCENDANT}_LIMIT` (Sebastian Falbesoner)
Pull request description:
This PR renames the default in-mempool max ancestors/descendants constants `MAX_ANCESTORS`/`MAX_DESCENDANTS` in the functional tests to match the ones in the codebase:
https://github.com/bitcoin/bitcoin/blob/c012875b9ded0a5183602f002738ca823d559518/src/policy/policy.h#L58-L59
https://github.com/bitcoin/bitcoin/blob/c012875b9ded0a5183602f002738ca823d559518/src/policy/policy.h#L62-L63
The custom limit constants `MAX_ANCESTORS_CUSTOM`/`MAX_DESCENDANTS_CUSTOM` are also renamed accordingly to better fit to this naming style. In the second commit, the default constants are deduplicated by moving them into the `messages.py` module. (Not sure if this module is really appropriate, as it doesn't have a connection to messages. If someone has a good suggestion, would be glad to hear it.)
ACKs for top commit:
w0xlt:
ACK https://github.com/bitcoin/bitcoin/pull/25810/commits/b4a5ab96b42957a0e2110525b9e2e450deda09c1
glozow:
utACK b4a5ab96b42957a0e2110525b9e2e450deda09c1
fanquake:
ACK b4a5ab96b42957a0e2110525b9e2e450deda09c1
Tree-SHA512: a15c8256170afce3e383fceddcb562f588a02be97ce4202c84a2ebf22d73ab843f5e5a7d7c98e9ea044d8bcb7a4aeae0081d0e84c53e8fc0edffbcca00460139
Diffstat (limited to 'src/test')
0 files changed, 0 insertions, 0 deletions