diff options
author | MarcoFalke <falke.marco@gmail.com> | 2018-12-11 13:56:35 -0500 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2018-12-11 13:56:38 -0500 |
commit | f65bce858f266b352c9ddd1f5480431dca56fcae (patch) | |
tree | 07e985507dc3d2fb6c3d95d3469ffa8776b3fa88 /src/test | |
parent | 7701b62561c4d39d0e111c9894c5455087c3c778 (diff) | |
parent | ee3b21dccbeb0f9d4e99de869dbfaf625c159c7f (diff) | |
download | bitcoin-f65bce858f266b352c9ddd1f5480431dca56fcae.tar.xz |
Merge #14886: [tests] Refactor importmulti tests
ee3b21dccb [tests] Add docstring for wallet_importmulti.py (John Newbery)
fbdba40594 [tests] add test_address method to wallet_import.py (John Newbery)
fd3a02c381 [tests] add test_importmulti method to wallet_import.py (John Newbery)
08a4a0f70f [tests] add get_multisig function to wallet_importmulti.py (John Newbery)
7c99614b40 [tests] add get_key function to wallet_importmulti.py (John Newbery)
e5a8ea8f14 [tests] tidy up imports in wallet_importmulti.py (John Newbery)
cb41ade6b1 [tests] fix flake8 warnings in wallet_importmulti.py (John Newbery)
Pull request description:
https://github.com/bitcoin/bitcoin/pull/14565 needs test coverage. This PR refactors wallet_importmulti.py to the following pattern:
1. Add `get_key()` and `get_multisig()` methods, which generate keys on node0 and return the priv/pubkeys and all scriptPubKey and address variants.
2. Add `test_importmulti()` method, which takes an importmulti request, sends it to node1 and tests against success and error codes/messages.
3. Add `test_address()` method, which takes an address, sends it as a getaddressinfo request to node1 and tests the values returned.
This does not add any specific testing for #14565, but makes it very straightforward to add that testing: `test_importmulti()` can be easily updated to test for returned warnings, and `test_address()` can be called multiple times against the different address variants for a singlesig/multisig.
Tree-SHA512: e0ae9d3436f0b4eec4f6b9bdc0f02aef49c5a16bbac319fd47b2cfcaf01d01780d7b296280e8760686a57fac63275eec09e2959d8aaeceae1b406d8eff768435
Diffstat (limited to 'src/test')
0 files changed, 0 insertions, 0 deletions