diff options
author | MarcoFalke <falke.marco@gmail.com> | 2021-03-23 15:57:52 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2021-03-23 15:57:58 +0100 |
commit | 837e59eff6acb03c6c93b5fd36a249c28b39eacf (patch) | |
tree | 8a740daef0d1ad8f594798dd99a740af94c4a607 /src/test | |
parent | 3c87dbe95c925274f80234ad4a88beb5a05fdfff (diff) | |
parent | d09ebc47233187ab8dd5a70df4d261353958978c (diff) | |
download | bitcoin-837e59eff6acb03c6c93b5fd36a249c28b39eacf.tar.xz |
Merge bitcoin-core/gui#248: Fix: For values of "Bytes transferred" and "Bytes/s" with 1000-based prefix names use 1000-based divisor instead of 1024-based
d09ebc47233187ab8dd5a70df4d261353958978c Fix wrong(1024) divisor for 1000-based prefixes (wodry)
Pull request description:
v.0.21.0
I saw in the GUI peer window in the "received" column `1007 KB`, and after increasing to >=1024 I guess, it switched to `1 MB`. I would have expected the display unit to change from KB to MB already at value >=1000.
I looked into the code, and the values appear to be power-of-2 byte values, so the switching at >=1024 and not >=1000 seems correct.
But the unit display is not precisely correct, binary prefixes should be used for power-of-2 byte values.
To be correct, this PR changes ~~KB/MB/GB to KiB/MiB/GiB.~~ KB to kB and the divisor from 1024 to 1000.
ACKs for top commit:
hebasto:
ACK d09ebc47233187ab8dd5a70df4d261353958978c, tested on Linux Mint 20.1 (Qt 5.12.8) the both "Network Traffic" and "Peers" tabs of the "Node Window".
jarolrod:
ACK d09ebc47233187ab8dd5a70df4d261353958978c
leonardojobim:
Tested ACK https://github.com/bitcoin-core/gui/pull/248/commits/d09ebc47233187ab8dd5a70df4d261353958978c on Ubuntu 20.04 Qt 5.12.8
Tree-SHA512: 8f830b08cc3fd36dc8a18f1192959fe55d1644938044bf31d770f7c3bf8475fba6da5019a2d2024d5b2c81a8dab112f360c555367814a14f4d05c89d130f25b0
Diffstat (limited to 'src/test')
0 files changed, 0 insertions, 0 deletions