diff options
| author | Daniel Kraft <d@domob.eu> | 2018-05-20 09:15:39 +0200 |
|---|---|---|
| committer | Daniel Kraft <d@domob.eu> | 2018-05-20 09:15:39 +0200 |
| commit | 60ebc7da4c2f918c821008088e88aba8ab40d867 (patch) | |
| tree | 64375d39d60874eb2a16b6c5760f6659eaac2b68 /src/test | |
| parent | d792e47421fcb9ce3b381c1e6d8902777ae3f9f3 (diff) | |
trivial: Mark overrides as such.
This trivial change adds the "override" keyword to some methods of
subclasses meant to override interface methods. This ensures that any
future change to the interface' method signatures which are not correctly
mirrored in the subclass will break at compile time with a clear error message,
rather than fail at runtime (which is harder to debug).
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/validation_block_tests.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/test/validation_block_tests.cpp b/src/test/validation_block_tests.cpp index f835570168..37c4f79133 100644 --- a/src/test/validation_block_tests.cpp +++ b/src/test/validation_block_tests.cpp @@ -25,12 +25,12 @@ struct TestSubscriber : public CValidationInterface { TestSubscriber(uint256 tip) : m_expected_tip(tip) {} - void UpdatedBlockTip(const CBlockIndex* pindexNew, const CBlockIndex* pindexFork, bool fInitialDownload) + void UpdatedBlockTip(const CBlockIndex* pindexNew, const CBlockIndex* pindexFork, bool fInitialDownload) override { BOOST_CHECK_EQUAL(m_expected_tip, pindexNew->GetBlockHash()); } - void BlockConnected(const std::shared_ptr<const CBlock>& block, const CBlockIndex* pindex, const std::vector<CTransactionRef>& txnConflicted) + void BlockConnected(const std::shared_ptr<const CBlock>& block, const CBlockIndex* pindex, const std::vector<CTransactionRef>& txnConflicted) override { BOOST_CHECK_EQUAL(m_expected_tip, block->hashPrevBlock); BOOST_CHECK_EQUAL(m_expected_tip, pindex->pprev->GetBlockHash()); @@ -38,7 +38,7 @@ struct TestSubscriber : public CValidationInterface { m_expected_tip = block->GetHash(); } - void BlockDisconnected(const std::shared_ptr<const CBlock>& block) + void BlockDisconnected(const std::shared_ptr<const CBlock>& block) override { BOOST_CHECK_EQUAL(m_expected_tip, block->GetHash()); |