aboutsummaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorMarcoFalke <falke.marco@gmail.com>2019-10-08 14:42:17 -0400
committerMarcoFalke <falke.marco@gmail.com>2019-10-24 14:58:34 -0400
commitfa928134075220254a15107c1d9702f4e66271f8 (patch)
treed21688f45f6634ef8ab2cb204991089a1daa8682 /src/test
parentd53828cb79688d72a18d2cc550dcd1dfe2d3dd85 (diff)
downloadbitcoin-fa928134075220254a15107c1d9702f4e66271f8.tar.xz
consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it
Diffstat (limited to 'src/test')
-rw-r--r--src/test/fuzz/transaction.cpp7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/test/fuzz/transaction.cpp b/src/test/fuzz/transaction.cpp
index 96d7947b07..383d879040 100644
--- a/src/test/fuzz/transaction.cpp
+++ b/src/test/fuzz/transaction.cpp
@@ -43,12 +43,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
}
CValidationState state_with_dupe_check;
- const bool valid_with_dupe_check = CheckTransaction(tx, state_with_dupe_check, /* fCheckDuplicateInputs= */ true);
- CValidationState state_without_dupe_check;
- const bool valid_without_dupe_check = CheckTransaction(tx, state_without_dupe_check, /* fCheckDuplicateInputs= */ false);
- if (valid_with_dupe_check) {
- assert(valid_without_dupe_check);
- }
+ (void)CheckTransaction(tx, state_with_dupe_check);
const CFeeRate dust_relay_fee{DUST_RELAY_TX_FEE};
std::string reason;