diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-08-19 14:22:20 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-08-19 15:04:34 +0200 |
| commit | e9b30126545d6ddd8772363e4079d1e4908ad117 (patch) | |
| tree | 14f466321b99541c0695ffa6e39ec00d44df1959 /src/test | |
| parent | 44ddcd887ddf3f62bcfb9c0b59ba2124335dbe94 (diff) | |
| parent | 71e0f07e9c5f0aef532b85c04807dcbedd04e0af (diff) | |
| download | bitcoin-e9b30126545d6ddd8772363e4079d1e4908ad117.tar.xz | |
Merge #19750: refactor: remove unused c-string variant of atoi64()
71e0f07e9c5f0aef532b85c04807dcbedd04e0af util: remove unused c-string variant of atoi64() (Sebastian Falbesoner)
Pull request description:
This is another micro-PR "removing old cruft with potentially sharp edges" (quote by practicalswift, see #19739). Gets rid of the c-string variant of the function `atoi64()`, which is only used in fuzzers and on one place with `wallet/wallet.h` (where it is originally a `std::string` anyways and uses `.c_str()` -- this method call can simply be removed.)
ACKs for top commit:
practicalswift:
ACK 71e0f07e9c5f0aef532b85c04807dcbedd04e0af -- diff looks correct
laanwj:
ACK 71e0f07e9c5f0aef532b85c04807dcbedd04e0af
Tree-SHA512: 4d1d28e2f5274fdbe0652e7a0f83dd416f4d19c1e1a49979927960a3ad40b0990eeaa4374656bf2c6998a965a14d62c1bc78303b7d583d3307c17828030a8e3b
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/fuzz/locale.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/test/fuzz/locale.cpp b/src/test/fuzz/locale.cpp index 3597f51e51..2b181c6da1 100644 --- a/src/test/fuzz/locale.cpp +++ b/src/test/fuzz/locale.cpp @@ -52,7 +52,6 @@ void test_one_input(const std::vector<uint8_t>& buffer) const bool parseint64_without_locale = ParseInt64(random_string, &parseint64_out_without_locale); const int64_t atoi64_without_locale = atoi64(random_string); const int atoi_without_locale = atoi(random_string); - const int64_t atoi64c_without_locale = atoi64(random_string.c_str()); const int64_t random_int64 = fuzzed_data_provider.ConsumeIntegral<int64_t>(); const std::string tostring_without_locale = ToString(random_int64); // The variable `random_int32` is no longer used, but the harness still needs to @@ -80,8 +79,6 @@ void test_one_input(const std::vector<uint8_t>& buffer) } const int64_t atoi64_with_locale = atoi64(random_string); assert(atoi64_without_locale == atoi64_with_locale); - const int64_t atoi64c_with_locale = atoi64(random_string.c_str()); - assert(atoi64c_without_locale == atoi64c_with_locale); const int atoi_with_locale = atoi(random_string); assert(atoi_without_locale == atoi_with_locale); const std::string tostring_with_locale = ToString(random_int64); |