diff options
author | MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> | 2023-02-02 10:40:34 +0100 |
---|---|---|
committer | MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> | 2023-02-02 10:40:40 +0100 |
commit | 102645280b945a0fbbbe67f8b55f1fc6b16b9b89 (patch) | |
tree | e66c4347095772f6e3a336fb37d7f6308ee535aa /src/test | |
parent | fdd363ebd917e5916742587608d59023ced513e1 (diff) | |
parent | 71383f2fad065378393ef55b6d65e14c656b7301 (diff) |
Merge bitcoin/bitcoin#27013: ci: avoid using `-Werror` for older compilers
71383f2fad065378393ef55b6d65e14c656b7301 ci: avoid using -Werror for older compilers (fanquake)
Pull request description:
Don't enable `-Werror` (in the CI) for compilers at least older than our current release compiler (GCC 10). It provides little-to-no value, other than turning compiler bugs & false positives into build failures, and we aren't going to mutate perfectly fine/working code, for the sake of avoid a warning that shouldn't even exist.
I also do not see the point of playing whack-a-mole and turning off various warnings/trying to further work around the broken compiler, just to acheive warningless builds for the sake of warningless builds.
One anecdote from ["How SQLite Is Tested"](https://www.sqlite.org/testing.html):
> Static analysis has found a few bugs in SQLite, but those are the
> exceptions. More bugs have been introduced into SQLite while trying
> to get it to compile without warnings than have been found by static
> analysis.
ACKs for top commit:
hebasto:
ACK 71383f2fad065378393ef55b6d65e14c656b7301
jarolrod:
ACK 71383f2fad065378393ef55b6d65e14c656b7301
Tree-SHA512: 20ed3dcf54fb17a7d9f0d8ca68c0ad2ee8f171f8bd61673a428f3123ab322c24cd9833f65915489bc8cebeffc37fd683a30e9669684b219960e69ddc7adae5bd
Diffstat (limited to 'src/test')
0 files changed, 0 insertions, 0 deletions