diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-04-12 19:33:27 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-12 19:38:18 -0400 |
| commit | 59d62492900f6fc6ade2a780e75863ba3b254e06 (patch) | |
| tree | 1f39e69631cfc7578c67d5ddf3e16d33fce9d324 /src/test/validation_chainstatemanager_tests.cpp | |
| parent | 76143bf714abade4a6d4068981c882e5cf0a2386 (diff) | |
| parent | 854382885f18aa9a95cdde3d11591b05c305ad3f (diff) | |
| download | bitcoin-59d62492900f6fc6ade2a780e75863ba3b254e06.tar.xz | |
Merge #18593: test: complete impl. of msg_merkleblock and wait_for_merkleblock
854382885f18aa9a95cdde3d11591b05c305ad3f refactor: test: improve wait_for{header,merkleblock} interface (Sebastian Falbesoner)
1356a45ef042e7bd3d539fbb606d6b1be547d00f test: complete impl. of msg_merkleblock and wait_for_merkleblock (Sebastian Falbesoner)
Pull request description:
Implements the missing initialization/serialization methods for `msg_merkleblock`, based on the already present class `CMerkleBlock`. Also changes the method `wait_for_merkleblock()` to be more precise by waiting for a merkleblock with a specified blockhash instead of an arbitrary one.
In the BIP37 test `p2p_filter.py`, this new method is used to make the test of receiving merkleblock and tx if a filter is set to be more precise, by checking if they also arrive in the right order.
In the course of this PR, also the interface for the methods `wait_for_merkleblock()` and `wait_for_header()` are improved to take a hex string instead of an integer, which is more typesafe and less of a burden to the caller.
ACKs for top commit:
MarcoFalke:
ACK 854382885f18aa9a95cdde3d11591b05c305ad3f
Tree-SHA512: adaf0ac728ef0b9929cb417a7a7b4c1346c400b2d365bf6914515c67b6cfe8f4a7ecc62fb514afdce9792f0bed833416f6bca6b9620f3d5dcdc66e4d5b0b7ea3
Diffstat (limited to 'src/test/validation_chainstatemanager_tests.cpp')
0 files changed, 0 insertions, 0 deletions