diff options
author | MarcoFalke <falke.marco@gmail.com> | 2017-11-15 12:49:48 -0500 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2017-11-15 12:50:17 -0500 |
commit | 4ed818060ecf4a38a02c8cb48f6cbc78d2ee7708 (patch) | |
tree | bdf5346b3bbefe3792f221f8f5e4e838d9c87b0f /src/test/util_tests.cpp | |
parent | 927a1d7d088e52aa079682e1d4f514222c0a2069 (diff) | |
parent | aed1d90aca81c20c6e982ad567291f3812d47c8f (diff) | |
download | bitcoin-4ed818060ecf4a38a02c8cb48f6cbc78d2ee7708.tar.xz |
Merge #10600: Make feebumper class stateless
aed1d90ac [wallet] Change feebumper from class to functions (Russell Yanofsky)
37bdcca3c [refactor] Make feebumper namespace (Russell Yanofsky)
7c4f00919 [trivial] Rename feebumper variables according to project code style (Russell Yanofsky)
Pull request description:
Make feebumper methods static and remove stored state in the class.
Having the results of feebumper calls persist in an object makes process
separation between Qt and wallet awkward, because it means the feebumper object
either has to be serialized back and forth between Qt and wallet processes
between fee bump calls, or that the feebumper object needs to stay alive in the
wallet process with an object reference passed back to Qt. It's simpler just to
have fee bumper calls return their results immediately instead of storing them
in an object with an extended lifetime.
In addition to making feebumper methods static, also:
- Move LOCK calls from Qt code to feebumper
- Move TransactionCanBeBumped implementation from Qt code to feebumper
- Rename CFeeBumper class to FeeBumper (every CFeeBumper reference had to be
updated in this PR anyway so this doesn't increase the size of the diff)
This change was originally part of https://github.com/bitcoin/bitcoin/pull/10244
Tree-SHA512: bf75e0c741b4e9c8912e66cc1dedf0ff715f77ea65fc33f7020d97d9099b0f6448f5852236dac63eea649de7d6fc03b0b21492e2c5140fb7560a39cf085506fd
Diffstat (limited to 'src/test/util_tests.cpp')
0 files changed, 0 insertions, 0 deletions