aboutsummaryrefslogtreecommitdiff
path: root/src/test/util/setup_common.h
diff options
context:
space:
mode:
authorCarl Dong <contact@carldong.me>2022-03-02 20:04:12 -0500
committerCarl Dong <contact@carldong.me>2022-05-31 14:18:31 -0400
commiteeb4fc20c578b1e428a92d64cc9f8f903a677580 (patch)
tree207246551b4c5133f4e549cc7e5bf91a86da7d82 /src/test/util/setup_common.h
parentd4d9daff7ab60a9f0cae0a34f86be0bb497f62f4 (diff)
test: Use Set/UnsetGlobals in BasicTestingSetup
...instead of calling initialization functions directly and having to keep around a ECCVerifyHandle member variable. This makes the initialization codepath of our tests more closely resemble those of AppInitMain and potentially eases the review of subsequent commit removing init::{Set,Unset}Globals. [META] In a future commit, we will introduce a kernel::Context which calls init::{Set,Unset}Globals in its ctor and dtor. It will be owned by node::NodeContext, so in the end, this patchset won't have made the previously local ECCVerifyHandle global.
Diffstat (limited to 'src/test/util/setup_common.h')
-rw-r--r--src/test/util/setup_common.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/test/util/setup_common.h b/src/test/util/setup_common.h
index a1b7525cf4..3030271827 100644
--- a/src/test/util/setup_common.h
+++ b/src/test/util/setup_common.h
@@ -81,7 +81,6 @@ static constexpr CAmount CENT{1000000};
* This just configures logging, data dir and chain parameters.
*/
struct BasicTestingSetup {
- ECCVerifyHandle globalVerifyHandle;
node::NodeContext m_node;
explicit BasicTestingSetup(const std::string& chainName = CBaseChainParams::MAIN, const std::vector<const char*>& extra_args = {});