diff options
| author | gzhao408 <gzhao408@berkeley.edu> | 2021-01-26 14:10:00 -0800 |
|---|---|---|
| committer | gzhao408 <gzhao408@berkeley.edu> | 2021-02-02 08:58:55 -0800 |
| commit | 158a0b268ca2f73a5d504791359d1eff2cf27715 (patch) | |
| tree | f652a7049a959bc6fe61b426caae7dc7c10cbf21 /src/test/transaction_tests.cpp | |
| parent | 0a76a39b633760d4668d39859605c05629ee0025 (diff) | |
| download | bitcoin-158a0b268ca2f73a5d504791359d1eff2cf27715.tar.xz | |
Apply maximal validation flags to tx_valid tests
- Apply all validation flags by default
- Invert the meaning of verifyFlags as flags being excluded
Co-authored-by: Johnson Lau <jl2012@xbt.hk>
Diffstat (limited to 'src/test/transaction_tests.cpp')
| -rw-r--r-- | src/test/transaction_tests.cpp | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp index 1eb30c68d6..4d03e6cec1 100644 --- a/src/test/transaction_tests.cpp +++ b/src/test/transaction_tests.cpp @@ -101,12 +101,6 @@ BOOST_FIXTURE_TEST_SUITE(transaction_tests, BasicTestingSetup) BOOST_AUTO_TEST_CASE(tx_valid) { // Read tests from test/data/tx_valid.json - // Format is an array of arrays - // Inner arrays are either [ "comment" ] - // or [[[prevout hash, prevout index, prevout scriptPubKey], [input 2], ...],"], serializedTransaction, verifyFlags - // ... where all scripts are stringified scripts. - // - // verifyFlags is a comma separated list of script verification flags to apply, or "NONE" UniValue tests = read_json(std::string(json_tests::tx_valid, json_tests::tx_valid + sizeof(json_tests::tx_valid))); ScriptError err; @@ -171,7 +165,7 @@ BOOST_AUTO_TEST_CASE(tx_valid) if (mapprevOutValues.count(tx.vin[i].prevout)) { amount = mapprevOutValues[tx.vin[i].prevout]; } - unsigned int verify_flags = ParseScriptFlags(test[2].get_str()); + unsigned int verify_flags = ~ParseScriptFlags(test[2].get_str()); const CScriptWitness *witness = &tx.vin[i].scriptWitness; BOOST_CHECK_MESSAGE(VerifyScript(tx.vin[i].scriptSig, mapprevOutScriptPubKeys[tx.vin[i].prevout], witness, verify_flags, TransactionSignatureChecker(&tx, i, amount, txdata), &err), |