diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2022-03-11 16:40:06 +0000 |
|---|---|---|
| committer | Andrew Chow <achow101-github@achow101.com> | 2022-03-11 16:40:17 +0000 |
| commit | c109e7d51c9c5614aafce184c63b52ad2e859eb2 (patch) | |
| tree | 205b3661a25f4c8b7140a8180e84f2361fd6dde4 /src/test/system_tests.cpp | |
| parent | a81717443f042b28604d5b19783bc0b5591ccee5 (diff) | |
| parent | ec7d73628a6397fca3b5b852d4e97ff918b6d3a6 (diff) | |
Merge bitcoin/bitcoin#24530: wallet: assert BnB's internally calculated waste is the same as GetSelectionWaste
ec7d73628a6397fca3b5b852d4e97ff918b6d3a6 [wallet] assert BnB internally calculated waste is the same as GetSelectionWaste() (glozow)
Pull request description:
#22009 introduced a `GetSelectionWaste()` function to determine how much "waste" a coin selection solution has, and is a mirror of the waste calculated inside of `SelectCoinsBnB()`. It would be bad for these two waste metrics to deviate, since it could negatively affect how often we select the BnB solution. Add an assertion to help tests catch a potential accidental change.
ACKs for top commit:
achow101:
ACK ec7d73628a6397fca3b5b852d4e97ff918b6d3a6
Xekyo:
ACK ec7d73628a6397fca3b5b852d4e97ff918b6d3a6
Tree-SHA512: 3ab7ad45ae92e7ce3f21824fb975105b6be8382edf47c252df5d13d973a3abdcb675132d223b42fcbb669cca879672c904b8a58d0676e12bf381a9219f4db37c
Diffstat (limited to 'src/test/system_tests.cpp')
0 files changed, 0 insertions, 0 deletions