diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-01-22 13:12:44 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-01-22 13:13:00 +0100 |
| commit | 32b191fb66e644c690c94cbfdae6ddbc754769d7 (patch) | |
| tree | 6e9bafa6bc6fed4314c92fc2de36d7d6c1122f15 /src/test/settings_tests.cpp | |
| parent | b7e12b350d3238fcdfea3bb4c2b064cdd9c43d81 (diff) | |
| parent | bf100f8170770544fb39ae6802175c564cde532f (diff) | |
Merge #20927: [refactor] [net] Clean up InactivityCheck()
bf100f8170770544fb39ae6802175c564cde532f [net] Cleanup InactivityChecks() and add commenting about time (John Newbery)
06fa85cd50b718fecd69f0481740d2b8714a1397 [net] InactivityCheck() takes a CNode reference (John Newbery)
Pull request description:
This is a pure refactor and should not change any behavior. It clarifies and documents the InactivityCheck() function
This makes #20721 easier to review. In particular, this function uses a mixture of (unmockable) system time and mockable time. It's important to understand where those are being used when reviewing #20721.
#20721 doesn't require this change, so if others don't agree that it's useful and makes review easier, then I'm happy to close this and just do #20721 directly.
ACKs for top commit:
fanquake:
ACK bf100f8170770544fb39ae6802175c564cde532f
MarcoFalke:
review ACK bf100f8170770544fb39ae6802175c564cde532f 💫
Tree-SHA512: 7b001de2a5fbe8a6dc37baeae930db5775290afb2e8a6aecdf13161f1e5b06ef813bc6291d8ee5cefcf1e430c955ea702833a8db84192eebe6e6acf0b9304cb2
Diffstat (limited to 'src/test/settings_tests.cpp')
0 files changed, 0 insertions, 0 deletions