diff options
author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-04-23 21:08:42 +0200 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-04-23 21:09:17 +0200 |
commit | a49381dfa3eec7765a842d3b990876e7f6b54f72 (patch) | |
tree | a1a64f1e937853280a863e2908cd680e4c6ed4d5 /src/test/rpc_tests.cpp | |
parent | 8609ddb368218c70c337a09bc3f354974bba1b26 (diff) | |
parent | 54a5a21158f740990048b1d43c641630744cf3ee (diff) |
Merge #12885: Reduce implementation code inside CScript
54a5a21 [MOVEONLY] Turn CScript::GetOp2 into a function and move to cpp (Pieter Wuille)
6a7456a [MOVEONLY] Move CSCript::FindAndDelete to interpreter (Pieter Wuille)
33a8ecf Delete unused non-const-iterator CSCript::GetOp overloads (Pieter Wuille)
2fb168b Make iterators in CScript::FindAndDelete const (Pieter Wuille)
Pull request description:
This PR moves `FindAndDelete` and `GetOp2` out of CScript (the first is only used inside the interpreter and moved there, the second does not actually depend on any script specifics and works on any vector). Furthermore, all non-const-iterator versions of GetOp are replaced by const ones, removing a number of methods in the process.
The longer term goal here is making the script interpreter independent from the CScript representation.
Note for reviewers: both `FindAndDelete` and `GetScriptOp` are consensus critical.
Tree-SHA512: c4ccf91c0b33c37cff0d474aa8dd2dab25b5b7655e2ed69a9b15e29daf0a67b21d51c23e1defb3a72ec762bd6138de96f69c6db1fb9c1fe1e976e421261aedb7
Diffstat (limited to 'src/test/rpc_tests.cpp')
0 files changed, 0 insertions, 0 deletions