aboutsummaryrefslogtreecommitdiff
path: root/src/test/rpc_tests.cpp
diff options
context:
space:
mode:
authorGregory Maxwell <greg@xiph.org>2017-01-04 08:51:14 +0000
committerGregory Maxwell <greg@xiph.org>2017-01-05 18:15:01 +0000
commitb3d7b1cbe7afdc6a63bbcbe938e8639deedb04a1 (patch)
tree6810829764a49ea735bd03584906dcd06f339d6f /src/test/rpc_tests.cpp
parent649cf5fe894b3f2db93d99392239c1405921c02e (diff)
Wallet: Do not perform ECDSA in the fee calculation inner loop.
Performing signing in the inner loop has terrible performance when many passes through are needed to complete the selection. Signing before the algorithm is complete also gets in the way of correctly setting the fee (e.g. preventing over-payment when the fee required goes down on the final selection.) Use of the dummy might overpay on the signatures by a couple bytes in uncommon cases where the signatures' DER encoding is smaller than the dummy: Who cares?
Diffstat (limited to 'src/test/rpc_tests.cpp')
0 files changed, 0 insertions, 0 deletions