diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-12-10 18:37:50 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-12-10 18:38:18 +0100 |
| commit | da957cd62ecc7fde5fa1dfcd134a73b388c2d438 (patch) | |
| tree | 887babd40bfa349f254f28177960c885800874be /src/test/reverselock_tests.cpp | |
| parent | b76abae387b9ac2526c315c95b0f2da8c78e16fc (diff) | |
| parent | fa918dd537fea775c19a590e5f9161bf51a5839b (diff) | |
| download | bitcoin-da957cd62ecc7fde5fa1dfcd134a73b388c2d438.tar.xz | |
Merge #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error
fa918dd537fea775c19a590e5f9161bf51a5839b test: Use Popen.wait instead of RPC in assert_start_raises_init_error (MarcoFalke)
Pull request description:
Using RPC (`wait_for_rpc_connection`) has several issue:
* It polls in a loop, which might be slow
* It tries to read the RPC cookie file, which might not be present, thus leading to intermittent issues
Fix both by using `Popen.wait`
ACKs for top commit:
laanwj:
Code review ACK ~~faf7b05be9c86ee61c39e5314511fe2410128a6b~~ fa918dd537fea775c19a590e5f9161bf51a5839b
darosior:
ACK fa918dd537fea775c19a590e5f9161bf51a5839b
Tree-SHA512: 5368ad0d0ea2deb0af9582a42667c9290efe8f2705f37a236afc2c7908b04265ab342e2dd356a57156e99389f4a27ab6da9fa7bf9161fb7568240aa005e693b9
Diffstat (limited to 'src/test/reverselock_tests.cpp')
0 files changed, 0 insertions, 0 deletions