diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-11-05 12:36:09 -0500 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-11-05 12:36:16 -0500 |
| commit | 54a337478dfbfede7c8335f6c7ab134817b73dcd (patch) | |
| tree | ed4cba5781991d7b7596ea1de2d18193435ff862 /src/test/net_tests.cpp | |
| parent | e204dc11b562c2cf31d320774a4dcbe49f3b6468 (diff) | |
| parent | 2493770e365a7e30117dc1b8d228f9cbed97f7e1 (diff) | |
| download | bitcoin-54a337478dfbfede7c8335f6c7ab134817b73dcd.tar.xz | |
Merge #17378: TestShell: Fix typos & implement cleanups
2493770e365a7e30117dc1b8d228f9cbed97f7e1 TestShell: Return self from setup() (James Chiang)
a8dea4552412668c2914b6395ef543341a9898cd TestShell: Simplify default setting of num_nodes (James Chiang)
9c7806e4bf113bee6c32cff7b46493fd1a5aa0ba Doc: Remove backticks in test-shell.md code block (James Chiang)
d3ed06e2cdb31dcecf5e647f7e1e52185cc76733 TestShell: Fix typo in TestShell warning printout (James Chiang)
Pull request description:
This PR follows up on #17288 and fixes typos and implements code clean-ups suggested by reviewers of 19139ee.
- Typo in `test_shell.py` warning
- Typo in `test-shell.md` code block
- Simplified default setting of `num_nodes` in `TestShell.setup()`
- Enable initializer chaining: `TestShell().setup()`
ACKs for top commit:
MarcoFalke:
ACK 2493770e365a7e30117dc1b8d228f9cbed97f7e1
instagibbs:
tACK https://github.com/bitcoin/bitcoin/pull/17378/commits/2493770e365a7e30117dc1b8d228f9cbed97f7e1
jnewbery:
utACK 2493770e365a7e30117dc1b8d228f9cbed97f7e1
Tree-SHA512: 8fa7c2c550dbc3ec899de9dc328cd55cfa6daafe3b888aa5427e72fea69f064d938ec68e15bfa57109c0f6c3583e627ac4bd69303a11575d056941bd253adee0
Diffstat (limited to 'src/test/net_tests.cpp')
0 files changed, 0 insertions, 0 deletions