diff options
| author | Pieter Wuille <pieter.wuille@gmail.com> | 2013-05-04 19:32:33 +0200 |
|---|---|---|
| committer | Pieter Wuille <pieter.wuille@gmail.com> | 2013-09-28 18:37:00 +0200 |
| commit | f5857e5cb5fb03bee9c05d1dd6ba2621cac49179 (patch) | |
| tree | 6d5347773c08f057b056de27a79fe890023db872 /src/test/multisig_tests.cpp | |
| parent | b41fa66ba7eaf3e56ce43bfb28114f59a7ea58ac (diff) | |
| download | bitcoin-f5857e5cb5fb03bee9c05d1dd6ba2621cac49179.tar.xz | |
Inline signature serializer
Instead of building a full copy of a CTransaction being signed, and
then modifying bits and pieces until its fits the form necessary
for computing the signature hash, use a wrapper serializer that
only serializes the necessary bits on-the-fly.
This makes it easier to see which data is actually being hash,
reduces load on the heap, and also marginally improves performances
(around 3-4us/sigcheck here). The performance improvements are much
larger for large transactions, though.
The old implementation of SignatureHash is moved to a unit tests,
to test whether the old and new algorithm result in the same value
for randomly-constructed transactions.
Diffstat (limited to 'src/test/multisig_tests.cpp')
| -rw-r--r-- | src/test/multisig_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/multisig_tests.cpp b/src/test/multisig_tests.cpp index 9ef932b5b4..7f6f141c62 100644 --- a/src/test/multisig_tests.cpp +++ b/src/test/multisig_tests.cpp @@ -19,7 +19,7 @@ using namespace boost::assign; typedef vector<unsigned char> valtype; -extern uint256 SignatureHash(CScript scriptCode, const CTransaction& txTo, unsigned int nIn, int nHashType); +extern uint256 SignatureHash(const CScript &scriptCode, const CTransaction& txTo, unsigned int nIn, int nHashType); BOOST_AUTO_TEST_SUITE(multisig_tests) |