diff options
| author | TheCharlatan <seb.kung@gmail.com> | 2023-11-17 20:28:14 +0100 |
|---|---|---|
| committer | TheCharlatan <seb.kung@gmail.com> | 2023-11-17 23:02:02 +0100 |
| commit | 705e3f1de00bf30d728addd52a790a139d948e32 (patch) | |
| tree | 3a48a2a69d555b000d6b085c210c35074581003b /src/test/fuzz | |
| parent | 22025d06e53f9bfccf88c600815f1cc496595d5d (diff) | |
refactor: Make CTxMemPoolEntry only explicitly copyable
This has the goal of prohibiting users from accidentally creating
runtime failures, e.g. by interacting with iterator_to with a copied
entry.
CTxMemPoolEntry is already implicitly not move-constructable. So be
explicit about this and use a std::list to collect the values in the
policy_estimator fuzz test instead of a std::vector.
Co-authored-by: Anthony Towns <aj@erisian.com.au>
Diffstat (limited to 'src/test/fuzz')
| -rw-r--r-- | src/test/fuzz/policy_estimator.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/fuzz/policy_estimator.cpp b/src/test/fuzz/policy_estimator.cpp index a6275d2fd2..ab885043d7 100644 --- a/src/test/fuzz/policy_estimator.cpp +++ b/src/test/fuzz/policy_estimator.cpp @@ -49,7 +49,7 @@ FUZZ_TARGET(policy_estimator, .init = initialize_policy_estimator) } }, [&] { - std::vector<CTxMemPoolEntry> mempool_entries; + std::list<CTxMemPoolEntry> mempool_entries; LIMITED_WHILE(fuzzed_data_provider.ConsumeBool(), 10000) { const std::optional<CMutableTransaction> mtx = ConsumeDeserializable<CMutableTransaction>(fuzzed_data_provider, TX_WITH_WITNESS); @@ -58,7 +58,7 @@ FUZZ_TARGET(policy_estimator, .init = initialize_policy_estimator) break; } const CTransaction tx{*mtx}; - mempool_entries.push_back(ConsumeTxMemPoolEntry(fuzzed_data_provider, tx)); + mempool_entries.emplace_back(CTxMemPoolEntry::ExplicitCopy, ConsumeTxMemPoolEntry(fuzzed_data_provider, tx)); } std::vector<const CTxMemPoolEntry*> ptrs; ptrs.reserve(mempool_entries.size()); |