diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2021-02-05 14:56:52 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2021-02-05 14:57:08 +0100 |
| commit | 173cf31299eba8176a82499932dd511676a607ff (patch) | |
| tree | f0b27e86f021c60a2fbe25a709fcba6c7d384cf4 /src/test/fuzz/fuzz.h | |
| parent | b829894f84839dfd581ec52383f93baa32ee2710 (diff) | |
| parent | faf7d7418cf01cb04cd457bcc630654da958a777 (diff) | |
| download | bitcoin-173cf31299eba8176a82499932dd511676a607ff.tar.xz | |
Merge #20839: fuzz: Avoid extraneous copy of input data, using Span<>
faf7d7418cf01cb04cd457bcc630654da958a777 fuzz: Avoid extraneous copy of input data, using Span<> (MarcoFalke)
Pull request description:
Seeing speedup here in the fuzz framework part (non-fuzz-target part). Speedup is only visible for input data larger than 100kB.
ACKs for top commit:
practicalswift:
cr ACK faf7d7418cf01cb04cd457bcc630654da958a777: patch looks correct :)
laanwj:
Code review ACK faf7d7418cf01cb04cd457bcc630654da958a777
Tree-SHA512: 41af7118846e0dfee237a6d5269a6c7cfbc775d7bd1cc2a85814cb60f6c2b37fe7fd35f1a788d4f08e6e0202c48b71054b67d2931160c445c79fc59e5347dadf
Diffstat (limited to 'src/test/fuzz/fuzz.h')
| -rw-r--r-- | src/test/fuzz/fuzz.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/test/fuzz/fuzz.h b/src/test/fuzz/fuzz.h index 52841e069a..19386a5059 100644 --- a/src/test/fuzz/fuzz.h +++ b/src/test/fuzz/fuzz.h @@ -5,12 +5,15 @@ #ifndef BITCOIN_TEST_FUZZ_FUZZ_H #define BITCOIN_TEST_FUZZ_FUZZ_H +#include <span.h> + #include <cstdint> #include <functional> #include <string_view> -#include <vector> -using TypeTestOneInput = std::function<void(const std::vector<uint8_t>&)>; +using FuzzBufferType = Span<const uint8_t>; + +using TypeTestOneInput = std::function<void(FuzzBufferType)>; using TypeInitialize = std::function<void()>; void FuzzFrameworkRegisterTarget(std::string_view name, TypeTestOneInput target, TypeInitialize init); @@ -21,13 +24,13 @@ inline void FuzzFrameworkEmptyFun() {} FUZZ_TARGET_INIT(name, FuzzFrameworkEmptyFun) #define FUZZ_TARGET_INIT(name, init_fun) \ - void name##_fuzz_target(const std::vector<uint8_t>&); \ + void name##_fuzz_target(FuzzBufferType); \ struct name##_Before_Main { \ name##_Before_Main() \ { \ FuzzFrameworkRegisterTarget(#name, name##_fuzz_target, init_fun); \ } \ } const static g_##name##_before_main; \ - void name##_fuzz_target(const std::vector<uint8_t>& buffer) + void name##_fuzz_target(FuzzBufferType buffer) #endif // BITCOIN_TEST_FUZZ_FUZZ_H |