diff options
author | fanquake <fanquake@gmail.com> | 2020-12-13 09:50:03 +0800 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2020-12-13 10:36:22 +0800 |
commit | ade38b6ee8f91e441507c0ee7ffe6ca020748991 (patch) | |
tree | ed8fff021d24ad21518be4e4011fa269632928c3 /src/test/fuzz/connman.cpp | |
parent | b18978066d875707af8e15edf225d3e52b5ade05 (diff) | |
parent | fac39c198324715565897f4240709340477af0bf (diff) | |
download | bitcoin-ade38b6ee8f91e441507c0ee7ffe6ca020748991.tar.xz |
Merge #20588: Remove unused and confusing CTransaction constructor
fac39c198324715565897f4240709340477af0bf wallet: document that tx in CreateTransaction is purely an out-param (MarcoFalke)
faac31521bb7ecbf999541cf918d3750ff589de4 Remove unused and confusing CTransaction constructor (MarcoFalke)
Pull request description:
The constructor is confusing and dangerous (as explained in the TODO), fix that by removing it.
ACKs for top commit:
laanwj:
Code review ACK fac39c198324715565897f4240709340477af0bf
promag:
Code review ACK fac39c198324715565897f4240709340477af0bf.
theStack:
Code review ACK fac39c198324715565897f4240709340477af0bf
Tree-SHA512: e0c8cffce8d8ee0166b8e1cbfe85ed0657611e26e2af0d69fde70eceaa5d75cbde3eb489af0428fe4fc431360b4c791fb1cc21b8dee7d4c7a4f17df00836229d
Diffstat (limited to 'src/test/fuzz/connman.cpp')
0 files changed, 0 insertions, 0 deletions