diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-10-02 13:39:34 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-10-02 13:40:39 +0200 |
| commit | 30c2b0b1cb110c27e329e453210561ea5dcdbeb5 (patch) | |
| tree | bb2470ddf2a97ec182adc64cd0dbd6a9ae8dc1ce /src/test/denialofservice_tests.cpp | |
| parent | 27322cd161dd03e60cf13cb5ba4bf8a73d66b614 (diff) | |
| parent | 2a4e60b48261d3f0ec3d85f97af998ef989134e0 (diff) | |
| download | bitcoin-30c2b0b1cb110c27e329e453210561ea5dcdbeb5.tar.xz | |
Merge #16849: Fix block index inconsistency in InvalidateBlock()
2a4e60b48261d3f0ec3d85f97af998ef989134e0 Fix block index inconsistency in InvalidateBlock() (Suhas Daftuar)
Pull request description:
Previously, we could release `cs_main` while leaving the block index in a state
that would fail `CheckBlockIndex()`, because `setBlockIndexCandidates` was not being
fully populated before releasing `cs_main`.
ACKs for top commit:
TheBlueMatt:
utACK 2a4e60b48261d3f0ec3d85f97af998ef989134e0. I also discovered another issue in InvalidateBlock while reviewing, see #16856.
Sjors:
ACK 2a4e60b. Tested on top of #16899. Also tested `invalidateblock` with `-checkblockindex=1`.
fjahr:
ACK 2a4e60b. Ran tests, reviewed code, inspected behavior while manually testing `invalidateblock`.
Tree-SHA512: ced12f9dfff0d413258c709921543fb154789898165590b30d1ee0cdc72863382f189744f7669a7c924d3689a1cc623efdf4e5ae3efc60054572c1e6826de612
Diffstat (limited to 'src/test/denialofservice_tests.cpp')
0 files changed, 0 insertions, 0 deletions