diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-03-07 00:04:56 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-03-07 00:09:48 +0100 |
| commit | b225010a808d475cbb53aeed484295f8dc8751c4 (patch) | |
| tree | 5ec8bb2bca595b84f4386d7da8abcccacaa7f898 /src/test/data | |
| parent | 29088b14ee4b3b3ef772af9ba3294fadd33a4d21 (diff) | |
| parent | 92f1f8b3197c2ba3cf65556070509838098975a4 (diff) | |
Merge #11372: Address encoding cleanup
92f1f8b31 Split off key_io_tests from base58_tests (Pieter Wuille)
119b0f85e Split key_io (address/key encodings) off from base58 (Pieter Wuille)
ebfe217b1 Stop using CBase58Data for ext keys (Pieter Wuille)
32e69fa0d Replace CBitcoinSecret with {Encode,Decode}Secret (Pieter Wuille)
Pull request description:
This PR contains some of the changes left as TODO in #11167 (and built on top of that PR). They are not intended for backporting.
This removes the `CBase58`, `CBitcoinSecret`, `CBitcoinExtKey`, and `CBitcoinExtPubKey` classes, in favor of simple `Encode`/`Decode` functions. Furthermore, all Bitcoin-specific logic (addresses, WIF, BIP32) is moved to `key_io.{h,cpp}`, leaving `base58.{h,cpp}` as a pure utility that implements the base58 encoding/decoding logic.
Tree-SHA512: a5962c0ed27ad53cbe00f22af432cf11aa530e3efc9798e25c004bc9ed1b5673db5df3956e398ee2c085e3a136ac8da69fe7a7d97a05fb2eb3be0b60d0479655
Diffstat (limited to 'src/test/data')
| -rw-r--r-- | src/test/data/key_io_invalid.json (renamed from src/test/data/base58_keys_invalid.json) | 0 | ||||
| -rw-r--r-- | src/test/data/key_io_valid.json (renamed from src/test/data/base58_keys_valid.json) | 0 |
2 files changed, 0 insertions, 0 deletions
diff --git a/src/test/data/base58_keys_invalid.json b/src/test/data/key_io_invalid.json index 2056c7491c..2056c7491c 100644 --- a/src/test/data/base58_keys_invalid.json +++ b/src/test/data/key_io_invalid.json diff --git a/src/test/data/base58_keys_valid.json b/src/test/data/key_io_valid.json index 8418a6002d..8418a6002d 100644 --- a/src/test/data/base58_keys_valid.json +++ b/src/test/data/key_io_valid.json |