diff options
author | Gregory Maxwell <greg@xiph.org> | 2016-05-29 01:36:52 +0000 |
---|---|---|
committer | Gregory Maxwell <greg@xiph.org> | 2016-05-30 22:07:56 +0000 |
commit | 63ff57db4beb2e92b3d8ed396da016f29f790195 (patch) | |
tree | 70f938749a9c7ca4e5401f382b485942cf3b181b /src/test/data/script_tests.json | |
parent | a80de15113166354cdf208e3d8b6e25f4511a591 (diff) |
Avoid integer division in the benchmark inner-most loop.
Previously the benchmark code used an integer division (%) with
a non-constant in the inner-loop. This is quite slow on many
processors, especially ones like ARM that lack a hardware divide.
Even on fairly recent x86_64 like haswell an integer division can
take something like 100 cycles-- making it comparable to the
runtime of siphash.
This change avoids the division by using bitmasking instead. This
was especially easy since the count was only increased by doubling.
This change also restarts the timing when the execution time was
very low this avoids mintimes of zero in cases where one execution
ends up below the timer resolution. It also reduces the impact of
the overhead on the final result.
The formatting of the prints is changed to not use scientific
notation make it more machine readable (in particular, gnuplot
croaks on the non-fixedpoint, and it doesn't sort correctly).
This also hoists out all the floating point divisions out of the
semi-hot path because it was easy to do so.
It might be prudent to break out the critical test into a macro
just to guarantee that it gets inlined. It might also make sense
to just save out the intermediate counts and times and get the
floating point completely out of the timing loop (because e.g.
on hardware without a fast hardware FPU like some ARM it will
still be slow enough to distort the results). I haven't done
either of these in this commit.
Diffstat (limited to 'src/test/data/script_tests.json')
0 files changed, 0 insertions, 0 deletions