diff options
author | MarcoFalke <falke.marco@gmail.com> | 2022-02-02 16:09:41 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2022-02-02 15:32:06 +0100 |
commit | fad81548fa03861c244397201d6b6e6cbf883c38 (patch) | |
tree | 2b38b968db8dfcc3e356ae5d058c8dad7a70219c /src/test/coins_tests.cpp | |
parent | 219d728fcbde8c313940788838afa46c2fb88762 (diff) | |
download | bitcoin-fad81548fa03861c244397201d6b6e6cbf883c38.tar.xz |
test: Avoid testing negative block heights
Diffstat (limited to 'src/test/coins_tests.cpp')
-rw-r--r-- | src/test/coins_tests.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/test/coins_tests.cpp b/src/test/coins_tests.cpp index 922fd8e513..82e4e1c90f 100644 --- a/src/test/coins_tests.cpp +++ b/src/test/coins_tests.cpp @@ -324,7 +324,7 @@ BOOST_AUTO_TEST_CASE(updatecoins_simulation_test) tx.vout.resize(1); tx.vout[0].nValue = i; //Keep txs unique unless intended to duplicate tx.vout[0].scriptPubKey.assign(InsecureRand32() & 0x3F, 0); // Random sizes so we can test memory usage accounting - unsigned int height = InsecureRand32(); + const int height{int(InsecureRand32() >> 1)}; Coin old_coin; // 2/20 times create a new coinbase @@ -393,11 +393,11 @@ BOOST_AUTO_TEST_CASE(updatecoins_simulation_test) // Update the expected result to know about the new output coins assert(tx.vout.size() == 1); const COutPoint outpoint(tx.GetHash(), 0); - result[outpoint] = Coin{tx.vout[0], int(height), CTransaction(tx).IsCoinBase()}; + result[outpoint] = Coin{tx.vout[0], height, CTransaction{tx}.IsCoinBase()}; // Call UpdateCoins on the top cache CTxUndo undo; - UpdateCoins(CTransaction(tx), *(stack.back()), undo, int(height)); + UpdateCoins(CTransaction{tx}, *(stack.back()), undo, height); // Update the utxo set for future spends utxoset.insert(outpoint); |