diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-07-22 16:31:11 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-07-22 16:33:00 +0200 |
| commit | a6f00ce66fe4f629ee52bff61bb4caf2c27dd970 (patch) | |
| tree | 02103f1d1052a017bae907a69aeed174f5a2ada3 /src/test/coins_tests.cpp | |
| parent | 6deac922e34dc3751a8b36c053579c9df9ad9b11 (diff) | |
| parent | 793290f940a9af18d4f0292a263d976a066dff65 (diff) | |
Merge #13212: Net: Fixed a race condition when disabling the network.
793290f940a9af18d4f0292a263d976a066dff65 Net: Fixed a race condition when disabling the network. (lmanners)
Pull request description:
This change addresses a race condition where setnetworkactive=false wouldn't always disconnect all peers.
Before this change, the following could happen:
1. Thread A -- Begins connecting to a node.
2. Thread B -- Sets kNetworkActive=false and disconnects connected nodes.
3. Thread A -- Finishes connecting and adds node to list of connected nodes.
The node that was connected from Thread A remains connected and active,
even though kNetworkActive=false.
To fix the race, disconnections when kNetworkActive=false are now handled in the main network loop.
fixes #13038
Tree-SHA512: 6d0b7a78ae956358e796efcc034cb532c2e0d824a52ae822a3899eefc7df76327519d1f2d77362c9fddf34ef860abd095d7490d7cc02d0ba7543bf1e8c8f2535
Diffstat (limited to 'src/test/coins_tests.cpp')
0 files changed, 0 insertions, 0 deletions