diff options
| author | Andrew Chow <github@achow101.com> | 2023-05-10 11:58:21 -0400 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-05-10 12:56:37 -0400 |
| commit | e0a70c5b4f2c691e8d6b507c8ce879f0b0424254 (patch) | |
| tree | 2858e09caa0d1748ed23205746458506463ba1c9 /src/test/blockmanager_tests.cpp | |
| parent | 104eed116614996d9724f82d47e373ef420cd372 (diff) | |
| parent | fa266c4bbf564308ddbc12653527226506902084 (diff) | |
Merge bitcoin/bitcoin#27605: refactor: Replace global find_value function with UniValue::find_value method
fa266c4bbf564308ddbc12653527226506902084 Temporarily work around gcc-13 warning bug in interfaces_tests (MarcoFalke)
fa28850562bda0c2049aaff42103dfa6f05395dc Fix clang-tidy performance-unnecessary-copy-initialization warnings (MarcoFalke)
faaa60a30e7738a1490c9c2bb8963420f53c7f2d Remove unused find_value global function (MarcoFalke)
fa422aeec2909df0151177816dc1ff5eb5a1fbab scripted-diff: Use UniValue::find_value method (MarcoFalke)
fa548ac872c094edc94c2afda5cc9b0d84f73af0 Add UniValue::find_value method (MarcoFalke)
Pull request description:
The global function has issues:
* It causes gcc-13 warnings, see https://github.com/bitcoin/bitcoin/issues/26926
* There is no rationale for it being a global function, when it acts like a member function
* `performance-unnecessary-copy-initialization` clang-tidy isn't run on it
Fix all issues by making it a member function.
ACKs for top commit:
achow101:
ACK fa266c4bbf564308ddbc12653527226506902084
hebasto:
re-ACK fa266c4bbf564308ddbc12653527226506902084
Tree-SHA512: 6c4e25da3122cd3b91c376bef73ea94fb3beb7bf8ef5cb3853c5128d95bfbacbcbfb16cc843eb7b1a7ebd350c2b6311f8085eeacf9aeeab3366987037d209e44
Diffstat (limited to 'src/test/blockmanager_tests.cpp')
0 files changed, 0 insertions, 0 deletions