diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-05-21 08:03:44 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-05-21 08:04:11 -0400 |
| commit | 3001cc61cf11e016c403ce83c9cbcfd3efcbcfd9 (patch) | |
| tree | 20098b5ec6bd90800cfc0d1a0e740f62d9219dfa /src/test/base58_tests.cpp | |
| parent | 2d1583ee6aff4b68dc46bcb87eb7a85f90b465c3 (diff) | |
| parent | 2c448d6bc7b2ac98da5171cf8f31c38a6324fb81 (diff) | |
Merge #13555: Tests: parameterize adjustment period in versionbits_computeblockversion
2c448d6bc7 parameterize hard coded numbers referring to miner conf window (Jordan Baczuk)
Pull request description:
Replace hard coded values (eg. 2016) with `mainnetParams.nMinerConfirmationWindow` where appropriate. This parameterizes hard coded values in the unit test that refer to the `Miner Confirmation Window`, which currently is `2016`. This includes values not exactly 2016 but which were derived from it. Also changed `int` to `uint32_t` where appropriate to avoid compiler warnings. This makes one source of truth, and also helps people who might be adjusting this value in testing so the unit tests don't break.
ACKs for commit 2c448d:
Tree-SHA512: 9262e0b89c1baf7857b49fe2221b2b00f948f61317b321c4871a9182a86d6f8aadeb59d6b133e8a213cc9b31b4a417888fb1ad31caef16ccbbab1de33c4b8459
Diffstat (limited to 'src/test/base58_tests.cpp')
0 files changed, 0 insertions, 0 deletions