diff options
| author | Pieter Wuille <pieter@wuille.net> | 2022-04-04 13:19:49 -0400 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-04-27 14:12:55 +0200 |
| commit | a65931e3ce66d87b8f83d67ecdbb46f137e6a670 (patch) | |
| tree | 1cdbaa2a15af7b87d7a963c4c759c2a29ddbe437 /src/test/base32_tests.cpp | |
| parent | a4377a0843636eae0aaf698510fc6518582545db (diff) | |
Make DecodeBase{32,64} always return vector, not string
Base32/base64 are mechanisms for encoding binary data. That they'd
decode to a string is just bizarre. The fact that they'd do that
based on the type of input arguments even more so.
Diffstat (limited to 'src/test/base32_tests.cpp')
| -rw-r--r-- | src/test/base32_tests.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/base32_tests.cpp b/src/test/base32_tests.cpp index 8a44e65165..2e5f6a2378 100644 --- a/src/test/base32_tests.cpp +++ b/src/test/base32_tests.cpp @@ -23,9 +23,9 @@ BOOST_AUTO_TEST_CASE(base32_testvectors) strEnc = EncodeBase32(vstrIn[i], false); BOOST_CHECK_EQUAL(strEnc, vstrOutNoPadding[i]); bool invalid; - std::string strDec = DecodeBase32(vstrOut[i], &invalid); + auto dec = DecodeBase32(vstrOut[i], &invalid); BOOST_CHECK(!invalid); - BOOST_CHECK_EQUAL(strDec, vstrIn[i]); + BOOST_CHECK_MESSAGE(MakeByteSpan(dec) == MakeByteSpan(vstrIn[i]), vstrOut[i]); } // Decoding strings with embedded NUL characters should fail |