diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2021-09-10 20:24:44 -0400 |
|---|---|---|
| committer | Andrew Chow <achow101-github@achow101.com> | 2021-10-08 13:53:48 -0400 |
| commit | 0fbaef9676a1dcb84bcf95afd8d994831ab327b6 (patch) | |
| tree | 4d41871f8100e99b7412983e5e7f028d15f6ecf8 /src/test/amount_tests.cpp | |
| parent | 927586990eb9bc8403a3831247847bdd3bf60423 (diff) | |
| download | bitcoin-0fbaef9676a1dcb84bcf95afd8d994831ab327b6.tar.xz | |
fees: Always round up fee calculated from a feerate
When calculating the fee for a given tx size from a fee rate, we should
always round up to the next satoshi. Otherwise, if we round down (via
truncation), the calculated fee may result in a fee with a feerate
slightly less than targeted.
This is particularly important for coin selection as a slightly lower
feerate than expected can result in a variety of issues.
Diffstat (limited to 'src/test/amount_tests.cpp')
| -rw-r--r-- | src/test/amount_tests.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/test/amount_tests.cpp b/src/test/amount_tests.cpp index 114fe3907c..aa23d71671 100644 --- a/src/test/amount_tests.cpp +++ b/src/test/amount_tests.cpp @@ -48,13 +48,13 @@ BOOST_AUTO_TEST_CASE(GetFeeTest) BOOST_CHECK_EQUAL(feeRate.GetFee(9e3), CAmount(-9e3)); feeRate = CFeeRate(123); - // Truncates the result, if not integer + // Rounds up the result, if not integer BOOST_CHECK_EQUAL(feeRate.GetFee(0), CAmount(0)); BOOST_CHECK_EQUAL(feeRate.GetFee(8), CAmount(1)); // Special case: returns 1 instead of 0 - BOOST_CHECK_EQUAL(feeRate.GetFee(9), CAmount(1)); - BOOST_CHECK_EQUAL(feeRate.GetFee(121), CAmount(14)); - BOOST_CHECK_EQUAL(feeRate.GetFee(122), CAmount(15)); - BOOST_CHECK_EQUAL(feeRate.GetFee(999), CAmount(122)); + BOOST_CHECK_EQUAL(feeRate.GetFee(9), CAmount(2)); + BOOST_CHECK_EQUAL(feeRate.GetFee(121), CAmount(15)); + BOOST_CHECK_EQUAL(feeRate.GetFee(122), CAmount(16)); + BOOST_CHECK_EQUAL(feeRate.GetFee(999), CAmount(123)); BOOST_CHECK_EQUAL(feeRate.GetFee(1e3), CAmount(123)); BOOST_CHECK_EQUAL(feeRate.GetFee(9e3), CAmount(1107)); |