diff options
author | Sebastian Falbesoner <sebastian.falbesoner@gmail.com> | 2021-10-21 16:03:03 +0200 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2022-02-15 09:22:05 +0000 |
commit | 227ae652542451834faddbaffb54fc384e9156e6 (patch) | |
tree | e67b44ceefc43a561e2868c82bff731fcd55fd65 /src/test/amount_tests.cpp | |
parent | 282863a7e9ddfb14ef02182945ca1978699dbe52 (diff) | |
download | bitcoin-227ae652542451834faddbaffb54fc384e9156e6.tar.xz |
wallet: fix segfault by avoiding invalid default-ctored `external_spk_managers` entry
In the method `CWallet::LoadActiveScriptPubKeyMan`, the map
`external_spk_managers` (or `internal_spk_managers`, if parameter
`internal` is false) is accessed via std::map::operator[], which means
that a default-ctored entry is created with a null-pointer as value, if
the key doesn't exist. As soon as this value is dereferenced, a
segmentation fault occurs, e.g. in `CWallet::KeypoolCountExternalKeys`.
The bevaviour can be reproduced by the following steps (starting with empty regtest datadir):
$ ./src/bitcoind -regtest -daemon
$ ./src/bitcoin-cli -regtest -named createwallet_name=wallet descriptors=true blank=true
$ cat regtest-descriptors.txt
[
{
"desc": "tr([e4445899/49'/1'/0']tprv8ZgxMBicQKsPd8jCeBWsYLEoWxbVgzJDatJ7XkwQ6G3uF4FsHuaziHQ5JZAW4K515nj6kVVwPaNWZSMEcR7aFCwL4tQqTcaoprMKTTtm6Zg/1/*)#mr3llm7f",
"timestamp": 1634652324,
"active": true,
"internal": true,
"range": [
0,
999
],
"next": 0
}
]
$ ./src/bitcoin-cli -regtest importdescriptors "$(cat regtest-descriptors.txt)"
[
{
"success": true
}
]
$ ./src/bitcoin-cli -regtest getwalletinfo
error: timeout on transient error: Could not connect to the server 127.0.0.1:18443 (error code 1 - "EOF reached")
Bug reported by Josef Vondrlik (josef-v).
Github-Pull: #23333
Rebased-From: 6911ab95f19d2b1f60f2d0b2f3961fa6639d4f31
Diffstat (limited to 'src/test/amount_tests.cpp')
0 files changed, 0 insertions, 0 deletions