diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-05-04 10:54:19 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-05-04 10:54:26 +0200 |
| commit | 14cb53dfe95ecf777afa85430cede609fb5379b4 (patch) | |
| tree | 237048aa63c7c7da5d1d0707d59f209097d1bdbd /src/test/allocator_tests.cpp | |
| parent | 9b42d62f426fd22602e4e9a589ab000e0f29a65b (diff) | |
| parent | fa4652ce5995ace831b6a4d3125bfcac9563ff6f (diff) | |
| download | bitcoin-14cb53dfe95ecf777afa85430cede609fb5379b4.tar.xz | |
Merge bitcoin/bitcoin#25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient
fa4652ce5995ace831b6a4d3125bfcac9563ff6f Pass lifetimebound reference to SingleThreadedSchedulerClient (MacroFake)
Pull request description:
Currently a pointer is passed, which is confusing and requires run-time asserts to avoid nullptr dereference.
All call sites can pass a reference, so do that. Also mark it LIFETIMEBOUND to avoid call sites passing a temporary. Also, unrelated cleanup in touched lines.
ACKs for top commit:
pk-b2:
ACK https://github.com/bitcoin/bitcoin/pull/25040/commits/fa4652ce5995ace831b6a4d3125bfcac9563ff6f
jonatack:
Code review ACK fa4652ce5995ace831b6a4d3125bfcac9563ff6f rebased to master, debug build, unit tests
vincenzopalazzo:
ACK https://github.com/bitcoin/bitcoin/pull/25040/commits/fa4652ce5995ace831b6a4d3125bfcac9563ff6f
Tree-SHA512: cd7ec77347e195d659b8892d34c1e9644d4f88552a4d5fa310dc1756eb27050a99d3098b0b0d27f8474230f82c178fd9e22e7018d8248d5e47a7f4caad395e25
Diffstat (limited to 'src/test/allocator_tests.cpp')
0 files changed, 0 insertions, 0 deletions