diff options
| author | John Newbery <john@johnnewbery.com> | 2021-08-05 13:51:52 +0100 |
|---|---|---|
| committer | John Newbery <john@johnnewbery.com> | 2021-08-18 14:00:52 +0100 |
| commit | ed9ba8af08f857bda3ce2f77413317374c22d7b4 (patch) | |
| tree | 4ee650b69fdb99c1fa4d97c2d5c9b6c0ed07c197 /src/test/addrman_tests.cpp | |
| parent | e8e7392311edf44278d76743bebe902d4ac94662 (diff) | |
[tests] Remove CAddrMan.Clear() call from CAddrDB::Read()
`bool CAddrDB::Read(CAddrMan& addr, CDataStream& ssPeers)` is _only_
called from the tests, and the call to addr.Clear() only exists so that
a test that Clear() is called passes. Remove that test and the call.
Diffstat (limited to 'src/test/addrman_tests.cpp')
| -rw-r--r-- | src/test/addrman_tests.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/test/addrman_tests.cpp b/src/test/addrman_tests.cpp index c52baa4e8b..255b5076e7 100644 --- a/src/test/addrman_tests.cpp +++ b/src/test/addrman_tests.cpp @@ -1083,13 +1083,12 @@ BOOST_AUTO_TEST_CASE(caddrdb_read_corrupted) BOOST_CHECK(addrman1.size() == 1); BOOST_CHECK(exceptionThrown); - // Test that CAddrDB::Read leaves addrman in a clean state if de-serialization fails. + // Test that CAddrDB::Read fails if peers.dat is corrupt CDataStream ssPeers2 = AddrmanToStream(addrmanCorrupted); CAddrMan addrman2(/* deterministic */ false, /* consistency_check_ratio */ 100); BOOST_CHECK(addrman2.size() == 0); BOOST_CHECK(!CAddrDB::Read(addrman2, ssPeers2)); - BOOST_CHECK(addrman2.size() == 0); } |