diff options
| author | Pieter Wuille <pieter@wuille.net> | 2021-03-01 18:07:14 -0800 |
|---|---|---|
| committer | Pieter Wuille <pieter@wuille.net> | 2021-03-15 17:29:39 -0700 |
| commit | 3820090bd619ac85ab35eff376c03136fe4a9f04 (patch) | |
| tree | 34d67616b6979bc195b722149989b99169139ba2 /src/signet.cpp | |
| parent | b77b0cc507bdc716e5236b1d9880e648147e0af9 (diff) | |
| download | bitcoin-3820090bd619ac85ab35eff376c03136fe4a9f04.tar.xz | |
Make all SignatureChecker explicit about missing data
Remove the implicit MissingDataBehavior::ASSERT_FAIL in the
*TransationSignatureChecker constructors, and instead specify
it explicit in all call sites:
* Test code uses ASSERT_FAIL
* Validation uses ASSERT_FAIL (through CachingTransactionSignatureChecker)
(including signet)
* libconsensus uses FAIL, matching the existing behavior of the
non-amount API (and the extended required data for taproot validation
is not available yet)
* Signing code uses FAIL
Diffstat (limited to 'src/signet.cpp')
| -rw-r--r-- | src/signet.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/signet.cpp b/src/signet.cpp index e68f031aa4..e41b94da8d 100644 --- a/src/signet.cpp +++ b/src/signet.cpp @@ -139,7 +139,7 @@ bool CheckSignetBlockSolution(const CBlock& block, const Consensus::Params& cons const CScript& scriptSig = signet_txs->m_to_sign.vin[0].scriptSig; const CScriptWitness& witness = signet_txs->m_to_sign.vin[0].scriptWitness; - TransactionSignatureChecker sigcheck(&signet_txs->m_to_sign, /*nIn=*/ 0, /*amount=*/ signet_txs->m_to_spend.vout[0].nValue); + TransactionSignatureChecker sigcheck(&signet_txs->m_to_sign, /*nIn=*/ 0, /*amount=*/ signet_txs->m_to_spend.vout[0].nValue, MissingDataBehavior::ASSERT_FAIL); if (!VerifyScript(scriptSig, signet_txs->m_to_spend.vout[0].scriptPubKey, &witness, BLOCK_SCRIPT_VERIFY_FLAGS, sigcheck)) { LogPrint(BCLog::VALIDATION, "CheckSignetBlockSolution: Errors in block (block solution invalid)\n"); |